Skip to content

fix(ui): fix reset-all-defaults and slider rounding for performance filters#2822

Merged
google-oss-prow[bot] merged 3 commits into
kubeflow:mainfrom
manaswinidas:fix-cold-start-bugs
Jun 15, 2026
Merged

fix(ui): fix reset-all-defaults and slider rounding for performance filters#2822
google-oss-prow[bot] merged 3 commits into
kubeflow:mainfrom
manaswinidas:fix-cold-start-bugs

Conversation

@manaswinidas

@manaswinidas manaswinidas commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Add missing COLD_START_LOAD_TIME and MAX_RPS to resetPerformanceFiltersToDefaults
  • Handle all number filter keys in getDefaultFiltersFromNamedQuery
  • Round slider range bounds and values to integers for GB-based filters
  • Update Cypress reset test to cover cold start filter
Screen.Recording.2026-06-12.at.8.52.45.PM.mov
Screenshot 2026-06-12 at 8 52 32 PM Screenshot 2026-06-12 at 9 11 26 PM

All applied and tested midstream

How Has This Been Tested?

  1. Test whether cold-start load time filters disappear on "Reset all defaults"
  2. Divider between the two filters on the sidebar
  3. Container size slider min and max values are rounded

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@manaswinidas
fix(ui): fix reset-all-defaults and slider rounding for performance f…
e14f1e1 
…ilters

Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
@github-actions github-actions Bot added Area/UI and removed size/M labels Jun 12, 2026
@manaswinidas
Fix Cypress tests
0960825 
Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
@manaswinidas manaswinidas force-pushed the fix-cold-start-bugs branch from eb088b3 to 0960825 Compare June 12, 2026 16:01
ppadti
ppadti suggested changes Jun 15, 2026
View reviewed changes

@ppadti ppadti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit: I still see the minimum vram and container size filters on performance insights, hardware table
I think it would be better if we separate them from ModelCatalogNumberFilterKey and PERFORMANCE_NUMBER_FILTER_KEYS into their own grouping (e.g., ModelCatalogHardwareFilterKey)?

Image

@manaswinidas
Remove min vRAM and container size chips from details page
d3f108d 
Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
@ppadti

ppadti commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/retest

ppadti
ppadti approved these changes Jun 15, 2026
View reviewed changes

@ppadti ppadti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor changes, we can do it #2838
we need to remove minimum vram and container size from resetPerformanceFiltersToDefaults() and add those to clearBasicFilters()

/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Jun 15, 2026
@google-oss-prow

google-oss-prow Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ppadti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 5ff24d6 into kubeflow:main Jun 15, 2026
38 of 39 checks passed
@ppadti ppadti mentioned this pull request Jun 16, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chambridge chambridge Awaiting requested review from chambridge

@Philip-Carneiro Philip-Carneiro Awaiting requested review from Philip-Carneiro

1 more reviewer

@ppadti ppadti ppadti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ppadti ppadti

Labels

approved Area/UI lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manaswinidas @ppadti